Core: added radio/checkbox to delegate click-event #1126
Conversation
|
seems like those were dropped while reworking the patch but not intentionally. @larslaade may I ask whats your use case is? when a user clicks a radio/checkbox the validiation should already be triggered by the focus-event. Do you trigger |
|
@staabm when the form validates and there are errors on radio/checkboxes, i click on those directly and the messages are not removed. when i use the version of my fork the messages are removed on click. Yes, they are removed when tabbing to the next input, but not when hitting space or clicking on it to select the radio/checkbox. |
|
hmm thats strange. Does you radio/checkbox already has the focus before you click on it? |
|
Landed, thanks for the patch. Good to have this fixed before a new release. |
| }); | ||
|
|
||
| events = [ | ||
| $.Event("click") |
There was a problem hiding this comment.
@jzaefferer I am not sure about this test-case... it actually only tests that click handlers are delegated, but thats not what browsers would do.
In a perfect world the focus event which is triggered before the click is dispatched would already have triggered the validation.
IMO the test should reflect what the issue actually was - clicking a invalid-radio/checkbox after validation should make it valid again.
I am aware that this test is more or less a copy of the test I added recently, but the point of my PR was to add those event handlers, therefore it was legit in my eyes.
|
@staabm @jzaefferer I've added a different test for that in #1128 |
Validation should work on click with radio/checkbox-elements.