Invalid element is not focused when validate a custom set of inputs #1327
Conversation
Invalid element is not focused when validate a custom set of inputs and the last one is a valid input.
The issue is showErrors method reset errorList state after validate each input so the global state of the validator is not preserved
| valid = true; | ||
| validator = $( this[ 0 ].form ).validate(); | ||
| this.each( function() { | ||
| valid = validator.element( this ) && valid; | ||
| errorList = errorList.concat( validator.errorList ); |
There was a problem hiding this comment.
should this lists only be merged in case the input/element is not valid?
There was a problem hiding this comment.
I don't know if you've noticed that from a performance view. In this case is more faster to do a var reference assignment rather than:
- get the
validvalue - then compare
- Optionally asign the var reference.
There was a problem hiding this comment.
Also I prefer don't discuss how make this fragment better. I think is better fix the problem inside of showError method, but I don't have more time for spent on this (too much time I spent for find the scenario and the source problem)
|
@jzaefferer Ping! Even if this is not be the best patch, at least fix the issue. This is the most important! |
|
I dug into this a bit, then landed it, after an update of the commit message. The |
Invalid element is not focused when validate a custom set of inputs and the last one is a valid input.
The issue is showErrors method reset errorList state after validate each input so the global state of the validator is not preserved.