@mattheworiordan can you provide a test case for this one?

Also, this seems to be a duplicate of #123

His fix seems to be a very strange fix, it has * at the end instead of nothing. Not sure that fix is right.

When you say can I provide a test case, can you be more explicit. Do I need to write a unit test or something like that, or do you want me to simply provide you with an example?

A simple unit test would be fine. Test validating matt@test.com. string, for example

Hi gmile

I have created a test and pushed that. Hope that is what you need.

Matt

Patch looks good. Asked Scott, who wrote that regex in the first place, to take a look, too.

@jzaefferer, can we use an ultimate RFC http://www.ex-parrot.com/pdw/Mail-RFC822-Address.html variant here?

I'm going to land this patch. The dot at the end is valid by the RFC, but really another exception we need to make.

Cool, well the . on the end is definitely not valid for an email address, so think this will fix an immediate problem.

@mattheworiordan it is valid by the RFC definition, according to Scott. He wrote the compiler for the regex. Not that it matters that much, as we're making other exceptions already.

Thanks, cherry-picked the commit to update the commit message and changelog. Note to self: Switch to script that exports changelog from commit log.