Skip to content

Conversation

thomasgohard
Copy link
Contributor

Allow both upper case and lower case characters and zero or more spaces between the Forward Sorting Area and Local Delivery Unit portions as users do not always use all upper case or include a space (see wet-boew/wet-boew#6760).

Correct the regular expression to fail entries that include invalid characters D, F, I, O, Q, and U which are not used in Canadian postal codes (emphasis mine):

The postal codeOM is a six-character code defined and maintained by Canada Post Corporation (CPC) for the purpose of sorting and delivering mail. The characters are arranged in the form 'ANA NAN', where 'A' represents an alphabetic character and 'N' represents a numeric character (e.g., K1A 0T6). The postal codeOM uses 18 alphabetic characters and 10 numeric characters. Postal codes do not include the letters D, F, I, O, Q or U, and the first position also does not make use of the letters W or Z.

-- Postal CodeOM Conversion File (PCCF), Reference Guide

@neoinsight
Copy link

@thomasgohard Please alert me when this branch is merged - we can then add a postal code field to the testing form. Thanks.

@thomasgohard
Copy link
Contributor Author

Any chance this can get looked at soon? We're waiting on this fix to continue our usability testing.

Thanks.

@staabm
Copy link
Member

staabm commented Aug 21, 2015

Looks good to me, thx.

staabm added a commit that referenced this pull request Aug 21, 2015
Additionals: Updates to postalCodeCA method

Allow both upper case and lower case characters and zero or more spaces between the Forward Sorting Area and Local Delivery Unit portions as users do not always use all upper case or include a space (see wet-boew/wet-boew#6760).

Correct the regular expression to fail entries that include invalid characters D, F, I, O, Q, and U which are not used in Canadian postal codes.
@staabm staabm merged commit f8e4be5 into jquery-validation:master Aug 21, 2015
@neoinsight
Copy link

@masterbee Am still waiting for this to be merged into WET master (or however that works) so that it works properly on the WET demos page. Another round of testing beginning soon...

@staabm
Copy link
Member

staabm commented Feb 3, 2016

@neoinsight WET?

@neoinsight
Copy link

@staabm Sorry, I don't know really know where it has to merged. What I need is for the postal code field on the WET demos page to works the way this says - with the more lenient postal code rules but still excluding invalid codes.
The current demos page here http://wet-boew.github.io/v4.0-ci/demos/formvalid/formvalid-en.html still shows an error message if I miss a space or use lower case, as per image below:
image

@staabm
Copy link
Member

staabm commented Feb 3, 2016

@neoinsight
Copy link

@masterbee The WET demos page still does not reflect commit f8e4be5 above, which was merged in August. If I type in a postal code without a space on WET Demos, I still get an error message. We have screenreader participants planned soon who will use the demo form, and @laurentgodderre updated the WET version but still could not get the postal code field working.

@staabm
Copy link
Member

staabm commented Apr 8, 2016

those WET demos are not part of this project and we cant influence which version of jquery-validate this external project use.

@neoinsight
Copy link

@staabm I see, I will post in GCWeb. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants