-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Additionals: Updates to postalCodeCA method #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additionals: Updates to postalCodeCA method #1536
Conversation
@thomasgohard Please alert me when this branch is merged - we can then add a postal code field to the testing form. Thanks. |
Any chance this can get looked at soon? We're waiting on this fix to continue our usability testing. Thanks. |
Looks good to me, thx. |
Additionals: Updates to postalCodeCA method Allow both upper case and lower case characters and zero or more spaces between the Forward Sorting Area and Local Delivery Unit portions as users do not always use all upper case or include a space (see wet-boew/wet-boew#6760). Correct the regular expression to fail entries that include invalid characters D, F, I, O, Q, and U which are not used in Canadian postal codes.
@masterbee Am still waiting for this to be merged into WET master (or however that works) so that it works properly on the WET demos page. Another round of testing beginning soon... |
@neoinsight WET? |
@staabm Sorry, I don't know really know where it has to merged. What I need is for the postal code field on the WET demos page to works the way this says - with the more lenient postal code rules but still excluding invalid codes. |
@masterbee The WET demos page still does not reflect commit f8e4be5 above, which was merged in August. If I type in a postal code without a space on WET Demos, I still get an error message. We have screenreader participants planned soon who will use the demo form, and @laurentgodderre updated the WET version but still could not get the postal code field working. |
those WET demos are not part of this project and we cant influence which version of jquery-validate this external project use. |
@staabm I see, I will post in GCWeb. Thanks |
Allow both upper case and lower case characters and zero or more spaces between the Forward Sorting Area and Local Delivery Unit portions as users do not always use all upper case or include a space (see wet-boew/wet-boew#6760).
Correct the regular expression to fail entries that include invalid characters D, F, I, O, Q, and U which are not used in Canadian postal codes (emphasis mine):