Fix validation of a single radio or checkbox input #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validator element() method delegates to check(). When check() is passed a radio or checkbox input element (call it 'A'), it instead checks the first element with the same name in the form (call it 'B'). If element B is judged invalid, a bug occurs. Element A will have been added to the currentElements array, but element B is what is added to the errorList. So, when showErrors is called, element A will be in validElements(), and will be unhighlighted. This is fixed by having element() also change its target to be the first element of the same name when passed a checkbox or radio input. Signed-off-by: Eric Naeseth <eric@thumbtack.com>
|
Patch looks good. Wondering if its reasonable to create a unit test for the issue. Could you take a look at that? Or @hdragomir? |
|
On this. |
|
@hdragomir: Thank you! I pulled the test commit into my feature branch. |
|
Thanks guys, landed! Did some rebasing to get this into one commit and include an update to the changelog. |
hdragomir
pushed a commit
to hdragomir/jquery-validation
that referenced
this pull request
Sep 20, 2011
…ckbox input The validator element() method delegates to check(). When check() is passed a radio or checkbox input element (call it 'A'), it instead checks the first element with the same name in the form (call it 'B'). If element B is judged invalid, a bug occurs. Element A will have been added to the currentElements array, but element B is what is added to the errorList. So, when showErrors is called, element A will be in validElements(), and will be unhighlighted. This is fixed by having element() also change its target to be the first element of the same name when passed a checkbox or radio input. Signed-off-by: Eric Naeseth <eric@thumbtack.com>
mlynch
pushed a commit
to mlynch/jquery-validation
that referenced
this pull request
Mar 28, 2012
…ckbox input The validator element() method delegates to check(). When check() is passed a radio or checkbox input element (call it 'A'), it instead checks the first element with the same name in the form (call it 'B'). If element B is judged invalid, a bug occurs. Element A will have been added to the currentElements array, but element B is what is added to the errorList. So, when showErrors is called, element A will be in validElements(), and will be unhighlighted. This is fixed by having element() also change its target to be the first element of the same name when passed a checkbox or radio input. Signed-off-by: Eric Naeseth <eric@thumbtack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validator element() method delegates to check(). When check() is passed a radio or checkbox input element (call it A), it instead checks the first element with the same name in the form (call it B).
If element B is judged invalid, the bug occurs. Element A will have been added to the currentElements array, but element B is what is added to the errorList. So, when showErrors is called, element A will be in validElements(), and will be unhighlighted.
This is fixed by having element() also change its target to be the first element of the same name when passed a checkbox or radio input, so that the element which is added to currentElements is the element which is actually checked.