Component: Support Bootstrap 4 #2131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional Bootstrap4 support Fixes jquery-validation#2130
|
Please add a separate demo instead of changing the existing one |
|
Here are the classes which have to be changed in the sample:
Other changes are needed to the sample:
|
|
Hi @vairamsvsjdo and @gwhenne, Could any of you create a new demo with Bootstrap v4 instead of updating the Boostrap v3 one? We don't want to replace that demo as there are still people using Boostrap v3 out there. Thanks! |
|
Hi there, I'm closing this PR in favor of #2173 which adds a new demo for Bootstrap v4. Thanks @vairamsvsjdo for your contribution, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional Bootstrap4 support
Fixes #2130
Checklist for this pull request
Existing tests must work
Description
The demo code for bootstrap requires change to Bootstrap 4 with Bootstrap 4 has reached stable.
Thank you!