-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Core: Use of jQuery attr instead of hasAttribute. (#2141) #2142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thx for the PR! how to reproduce the issue you are fixing? which IE version is affected? |
Hi, Open the page When focusing out from the first field, the error appears. |
This is my validation setup:
|
We definetly should drop older versions of jQuery in the next major release and stick to versions |
hmm either the linked issue was added after I did the comment or I missed it completely.
big 👍 . we should gather some information which usefull BC breaks we should target for 2.0. |
Hi @lopezcjf, Sorry for taking so long to review this. I did some research in order to have a global understanding of this issue and I was wrong suggesting using So, can you please update this PR to use |
Hi @lopezcjf, Just a friendly reminder. Are you still willing to continue this PR? No worries if you don't have time for it, though. Thanks! |
Fixes not supported method hasAttribute on IE7 Fixes jquery-validation#2141
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lopezcjf,
I did the changes I requested in my comment #2142 (comment) on your behalf. Don't worry, I kept the attribution intact (the commit is still authored by you).
I'll merge this PR now.
Thansk for your contribution :)
Fixes not supported method hasAttribute on IE with enabled compatibility mode
Fixes #2141