Addition Methods: New method nisBr (#2196) #2203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes new implementation Fixes jquery-validation#2169
File commited wrong
Fixes new implementation Fixes jquery-validation#2196
…validation into nis-br-method
Arkni
reviewed
Aug 21, 2018
| */ | ||
|
|
||
| $.validator.addMethod( "nisBR", function( value ) { | ||
|
|
| * @Description Brazillian PIS or NIS number (Número de Identificação Social Pis ou Pasep) is the equivalent of a | ||
| * Brazilian tax registration number NIS of PIS numbers have 11 digits in total: 10 numbers followed by 1 check numbers | ||
| * that are being used for validation. | ||
| * @copyright (c) 25/10/2016 22:40, Cleiton da Silva Mendonça |
There was a problem hiding this comment.
I think this is a copy-paste error. Can you please adjust the date to the right one.
| //Get check number of value | ||
| cn = parseInt( value.substring( 10, 11 ), 10 ); | ||
|
|
||
| //Get number with 10 digits of the value |
There was a problem hiding this comment.
Please add a space before this comment and the one above it in order to be consistent with the rest of the comments.
cleitonmendonca
added a commit
to cleitonmendonca/jquery-validation
that referenced
this pull request
Aug 21, 2018
Rewrite with reviews some mistakes Fixes jquery-validation#2203
|
Hi @Arkini, Thanks for your attention. |
cleitonmendonca
added a commit
to cleitonmendonca/jquery-validation
that referenced
this pull request
Aug 21, 2018
Rewrite with reviews some mistakes Fixes jquery-validation#2203
cleitonmendonca
added a commit
to cleitonmendonca/jquery-validation
that referenced
this pull request
Aug 21, 2018
Reviewer of new method nisBr, removing extra spaces. Fixes jquery-validation#2203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes new implementation
Fixes #2196
Description
Thank you!