Added CNH Validation (Brazilian License Driver) #2221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A validation of CNH (Brazilian License Driver)
Added portuguese message for CNH validation
|
Thanks for your contribution! I'll triage and take a look at it as soon as possible! |
Arkni
requested changes
Oct 6, 2018
There was a problem hiding this comment.
Hi @joaoissamu,
Thanks for your contribution. Overall, the PR looks good to me. The only things needed are to fix the code style issues (see full report here https://travis-ci.org/jquery-validation/jquery-validation/builds/435727273?utm_source=github_status&utm_medium=notification) and to add a test for your new method. The test should be under test/additional/cnhBr.js and should be also added to index.html after these two lines:
jquery-validation/test/index.html
Lines 18 to 19 in 3a7e593
Thanks!
|
Closed in favor of #2234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thank you!