Added checkbox test to require_from_group and changed require_from_group to use elementValue #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting two failing assertions in "additional methods: skip_or_fill_minimum". Could you look into those? While at it, please also update the commit message to reference the ticket. |
|
@jzaefferer this is because it relies on #368, since elementValue (without #368) returns the value of the checkboxes even if they aren't checked. What do you suggest I do? |
|
#368 landed, so what's the problem? |
…oup to use elementValue
Removed unnecessary resetting of checkbox
|
Landed in c3ce5b4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #359, but relies on #368, specifically the changes to elementValue that make it function properly for checked elements (radios, checkboxes).