Added field comparison functions #458
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These new functions allow you to check 2 fields against each other passing the second field as the parameters. I have added greaterThan greaterThanEqualTo lessThan lessThanEqualTo
|
Thanks for the contribution. Could you add unit tests and clean up the code to match the style of the rest of the codebase? For example, put the |
|
I'd land this with unit tests and some code cleanup. If someone finds this and wants to help out, I'd land a better PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new functions allow you to check 2 fields against each other
passing the second field as the parameter.
I have added
greaterThan
greaterThanEqualTo
lessThan
lessThanEqualTo