Removed dots at end of sentences #568
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dots are not necessary and they sometimes display on the wrong side of the sentence
|
Thanks for the contribution. It looks like you (or your editor) changed the indentation - could you fix that? It should be all tabs. |
|
I used the GitHub editor. It is on indent mode 'tab' with indent size '8'. |
|
So this will not be merged? Because, like I said, it's github's editor doing the indentation... |
|
Finally figured out that you removed the wrapper, that caused the indentation to change, while still using tabs. Undid that and updated the commit message. Thanks! |
|
Oops. Sorry for the trouble... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dots are not necessary and they sometimes display on the wrong side of the sentence