Skip to content

Absolute minimum jQuery 1.9 patch #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Absolute minimum jQuery 1.9 patch #613

wants to merge 2 commits into from

Conversation

seriema
Copy link
Contributor

@seriema seriema commented Jan 30, 2013

This is the minimal needed to upgrade to jQuery 1.9.

@jzaefferer
Copy link
Collaborator

Thanks! Its interesting that only the second attr call needs to be changed to make the test pass...

@seriema
Copy link
Contributor Author

seriema commented Jan 30, 2013

The first use is wrong IMHO because the jQuery docs recommend either attr('checked', 'checked') or prop('checked', true). Regardless it should be symmetric use of either attr or prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seriema @jzaefferer