Skip to content

some netherlands specific validations added #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

some netherlands specific validations added #628

wants to merge 7 commits into from

Conversation

digitalica
Copy link
Contributor

as discussed in email.

@jzaefferer
Copy link
Collaborator

Thanks. Can you look at the lint errors Travis lists? Run grunt lint locally to test yourself.

account = value.replace(/ /g,''); // remove spaces
var sum = 0;
var len = account.length;
for (pos=0; pos<len; pos++) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably delete the line above and use this

for (var pos = 0, len = account.length; pos < len; pos++) {

@digitalica
Copy link
Contributor Author

You're right. I installed grunt, ran it and fixed the code.

@digitalica
Copy link
Contributor Author

done, including the grunt install.... Grunt was right.

robbert

On Wed, Feb 6, 2013 at 3:18 PM, Jörn Zaefferer notifications@github.comwrote:

Thanks. Can you look at the lint errors Travis lists? Run grunt lintlocally to test yourself.


Reply to this email directly or view it on GitHubhttps://github.com//pull/628#issuecomment-13183615.

Robbert Wethmar
Digitalica
Jan Evertsenstraat 144 A4
1056 EK Amsterdam
phone 06 53804879

@digitalica
Copy link
Contributor Author

this pull request is a bit of a mess now...

I think i'll just until my other pull request (IBAN, pull request #630) is integrated, and then clean & redo this one.

@jzaefferer
Copy link
Collaborator

Thanks! Squashed into one commit, in 509e6e3

@jzaefferer jzaefferer closed this Feb 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants