postcodeUK method Fixed #682
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks. Could you add a unit test for this as well? Take a look at the existing tests in |
|
I need to amend this request i need to pass in 'value' not 'postcode'. My IDE must not have saved this changed when I commit.. My bad.. |
|
That part looks fine to me. |
added 2 commits
March 13, 2013 09:25
| ok( method( "A99 9AA" ), "Valid postcode" ); | ||
| ok( method( "AA9 9AA" ), "Valid postcode" ); | ||
| ok( method( "AA99 9AA" ), "Valid postcode" ); | ||
| ok(!method( "AAAA 9AA" ), "Invalid postcode" ); // Channel Island |
There was a problem hiding this comment.
These are a non standard UK postcode and does not follow rest of UK
|
Any word on its implementation? |
|
Yes, just landed, thanks! I've squashed into a single commit, updated the commit message and removed some trailing whitespace. |
ruado1987
pushed a commit
to ruado1987/jquery-validation
that referenced
this pull request
Mar 22, 2013
…loses jquery-validation#682 Old one allows integers between 5-7 digits which is not valid. New one is still case insensitive and allows spaces & fixes the above issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote the postcodeUK method to filter out more invalid postcodes.
Old one allows integers between 5-7 digits which is not valid.
New one is still case insensitive and allows spaces & fixes the above issue.