Fixes issue 401 which causes error when nested form created programatica... #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ically by code or third-party library
|
@jzaefferer : Any update on this PR? It has been around here for nearly a week. |
|
Sorry. Didn't have time since doing the 1.11.1 release. I'll check this out when I'm back home next week. |
|
Alright. Thanks. |
|
Thank you for the PR, but nested forms are invalid in HTML5. This comment provides a workaround specifically for the plupload issue: #401 (comment) |
|
Indeed, it is invalid in HTML5 but the problem is that other libraries generate a form into the DOM dynamically, such as plupload (https://github.com/moxiecode/plupload/blob/1.5.7/src/javascript/plupload.html4.js#L89). Our case is an Maybe just ignore validations of fields from nested forms? |
Arkni
added a commit
to Arkni/jquery-validation
that referenced
this pull request
Mar 4, 2018
Arkni
added a commit
to Arkni/jquery-validation
that referenced
this pull request
Mar 4, 2018
Arkni
added a commit
that referenced
this pull request
Mar 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jzaefferer: This PR replaces issue #401.