Skip to content

Verify nine-digit zip codes. #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

johana-star
Copy link
Contributor

No description provided.

@johana-star
Copy link
Contributor Author

There was a typo in the regex and nine-digit zip codes (90210-4567) weren't being properly matched.

@jzaefferer
Copy link
Collaborator

Thanks. I added that number to the unit tests, though I didn't actually fail without your modifcation. Still, the fix makes sense.

@goodeye
Copy link

goodeye commented May 18, 2013

The error was extra digits in front, e.g., 123456-7890, matching 23456-7890 instead of failing. Extra digits now fail, which is good.

@johana-star
Copy link
Contributor Author

Something like that: http://rubular.com/r/qDE6GNsXb4

@jzaefferer
Copy link
Collaborator

Thanks, I extended the unit test for that: b51e86f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants