Additional prefix in UK. #750
Conversation
|
Thanks. Could you add sample numbers to the unit tests for each? |
| @@ -389,14 +389,14 @@ jQuery.validator.addMethod('phoneUK', function(phone_number, element) { | |||
| jQuery.validator.addMethod('mobileUK', function(phone_number, element) { | |||
| phone_number = phone_number.replace(/\(|\)|\s+|-/g,''); | |||
| return this.optional(element) || phone_number.length > 9 && | |||
| phone_number.match(/^(?:(?:(?:00\s?|\+)44\s?|0)7(?:[45789]\d{2}|624)\s?\d{3}\s?\d{3})$/); | |||
| phone_number.match(/^(?:(?:(?:00\s?|\+)44\s?|0)7(?:[1345789]\d{2}|624)\s?\d{3}\s?\d{3})$/); | |||
There was a problem hiding this comment.
[1345789] could also be expressed as [^26\D], but I don't know if that would hurt readability
There was a problem hiding this comment.
I usually try to avoid negatives, for that very reason.
Additionally, [345] could be expressed as [3-5] and [789] could be expressed as [7-9] but it is the same number of characters.
In a few years time, when 072xx xxxxxx numbers come into use, it can be simplified to 7([1-5789]\d{2}|624)\d{6} and by then it may be that the rest of 76xx beyond 7624 has been opened up too allowing the much simplified 7[1-9]\d{8} instead.
|
Thanks! Landed as a single commit. Btw. when you add commits, adding a comment here helps, since there's no notifications for new commits. |
|
Thanks! I wasn't aware of the lack of notifications. I'll add a comment next time. |
It will be another 4 or 5 years before the next mobile prefix change after that.