Problem with not running validation when onfocusout is called. #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a problem with plugin not validating fields when focus is out. This was reported by some people to work on "random" basis. The problem is on line 239. The check fails because `this.optional` returns string `"dependency-mismatch"` and the whole if statement returns wrong bool result. Sometimes it works, because the field is in `this.submited` array The whole method `optional` should be probably changed. This change fix problem for me, but I'm not sure about other use cases. I'm not knee deep in the code.
|
@nschonni could you review this? |
|
Not validating till submit matches the HTML5 behaviour (vanilla example without this library http://jsfiddle.net/DYRLR/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with plugin not validating fields when focus is out. This was reported by some people to work on "random" basis.
The problem is on line 239. The check fails because
this.optionalreturns string"dependency-mismatch"and the whole if statement returns wrong bool result. Sometimes it works, because the field is inthis.submitedarrayThe whole method
optionalshould be probably changed.This change fix problem for me, but I'm not sure about other use cases.
I'm not knee deep in the code.