[JRUBY-6963] PKCS7 structures that have their content encapsulated in a sequence are not imported correctly #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re not imported correctly The case to handle content which has been encapsulated in a sequence has been in place already but wasn't implemented. The fix is inspired by Pull Request: jruby/jruby-ossl#9. The test case includes PKCS7 samples to showcase the issue. Credit goes to Jason Franklin [https://github.com/jamuc] for helping with the samples and the fix in general.
|
Incorporated in commit acdb0d1 and the test was added to ruby/ruby#205. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case to handle content which has been encapsulated in a sequence has been in place already but wasn't implemented. The fix is inspired by Pull Request: jruby/jruby-ossl#9. The test case includes PKCS7 samples to showcase the issue. Credit goes to Jason Franklin for helping with the samples and the fix in general.
See also issue JRUBY-6963.