Correct notice on attributes in remove function #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The notice stated that path, domain and secure attributes needs to be the same as when the cookie was created when removing a cookie, but in reality only the path and domain attributes needs to be the same. This commit removes "secure" from this notice.
|
That is a freaking awesome commit! |
|
Oh, now I realized, it is not an awesome commit because you changed |
|
Ahh, so close! I agree with you though, smaller commit without any noise is definitely preferable :) I'll try to suppress my inner grammar voice the next time ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notice stated that path, domain and secure attributes needs to be the same
as when the cookie was created when removing a cookie, but in reality only the
path and domain attributes needs to be the same. This commit removes "secure"
from this notice.