Allow undocumented attributes to be passed when creating a cookie #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also creates a reference in the related test to the specific issue we're handling here. It also workarounds QUnit's parameter trap by creating the 'actual' and 'expected' variables according to the current standard throughout the test file
This work had a lot of changes and the latest one managed to put it down to 901 bytes gzipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a green light to support all custom attributes. js-cookie only supports and documents attributes described in the public API documentation because they are usually known to work in most browsers. Anything different than that should be considered unsafe.
Feel free to propose a Pull Request and open a discussion to document a new attribute. However, keep in mind that, for the sake of trust, we will only document attributes that most browsers implement (or make it clear otherwise).
The motivation for this was the several reports regarding the
SameSiteattribute.See #276, #275 and #264 for some context.
The authorship of this goes to @kukulich for his effort, as declared in this comment. Thanks!