Skip to content

Update LICENSE #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update LICENSE #425

wants to merge 1 commit into from

Conversation

PrestonL
Copy link
Contributor

@PrestonL PrestonL commented Apr 2, 2018

Updated LICENSE file per conversation with project maintainer

Updated LICENSE file per conversation with project maintainer
@@ -1,4 +1,4 @@
Copyright 2014 Klaus Hartl
Copyright 2006, 2014, 2015 Klaus Hartl & Fagner Brack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to specify the dates like 2006, 2014 and 2015? Can't we just put 2018?

@FagnerMartinsBrack
Copy link
Member

X-Ref: #424.

@PrestonL, given our conversation on #424, is there any other action to do in this regard?

@PrestonL
Copy link
Contributor Author

I would recommend:

Copyright 2006-2018 Klaus Hartl, Fagner Brack, GitHub Contributors

or even with just the current year:

Copyright 2018 Klaus Hartl, Fagner Brack, GitHub Contributors

I believe the GitHub Terms of Service "Contributions Under Repository License" clause sufficiently covers everything and agree that no CLA is needed as discussed in #424

The Terms of Service don't necessarily transfer copyright ownership of contributions to the project or maintainer, so attributing all the contributors as a whole does seem it would be an appropriate practice as OpenStreetMap does (they always say Copyright OpenStreetMap Contributors); has a side effect of gives good vibes by crediting the contributors as well.

Glad we were all able to dig into and learn something on that.

Thanks for all your work!

@FagnerMartinsBrack
Copy link
Member

@PrestonL Do you wanna make the change then? After that change, it LGTM. Let's keep it for a while to see if there's any additional feedback.

Can you post a permalink to OpenStreetMap License or other examples for future context?

@PrestonL PrestonL mentioned this pull request Apr 24, 2018
@PrestonL
Copy link
Contributor Author

Sure, I created a new pull request and referenced this one in it. Here is the example license and attribution format used by Open Street Map for reference:

https://www.openstreetmap.org/copyright

@PrestonL PrestonL closed this Apr 24, 2018
@FagnerMartinsBrack
Copy link
Member

FagnerMartinsBrack commented Apr 25, 2018

@PrestonL You don't need to create a new Pull Request, just push changes to the branch patch-1 of your fork.

FagnerMartinsBrack pushed a commit that referenced this pull request Apr 28, 2018
Uses MIT Template from GitHub so that MIT message is shown at the top and makes changes to contributors as discussed in gh-425

Closes gh-433. Closes gh-424.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants