Skip to content

Write converter #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 8, 2015
Merged

Write converter #71

merged 17 commits into from
Nov 8, 2015

Conversation

FagnerMartinsBrack
Copy link
Member

When calling Cookies.withConverter, you can pass either a function to
use as the read converter, or an Object Literal with the properties
read and write.

image

When calling "Cookies.withConverter", you can pass either a function to
use as the read converter, or an Object Literal with the properties
"read" and "write".
@FagnerMartinsBrack
Copy link
Member Author

(@dezlov, it seems that your comment was removed from this PR on rebase, so I will replicate here:)

@dezlov:
I didn't have chance to verify that converters above actually work with PHP, but I've noticed few other problems.

  1. Typo in Cookies.withConverter(...), it is called with 2 x write properties. (fixed in latest version)
  2. Usage of setrawcookie() is missing as documented in Optional encoder function, in addition to decoder (converter) #70 (comment), it's quite important:

In PHP, use setrawcookie() instead of setcookie():

setrawcookie($name, rawurlencode($value));

@FagnerMartinsBrack
Copy link
Member Author

I didn't have chance to verify that converters above actually work with PHP

I didn't tested it either. It is just a reference documentation to workaround server-side incompatibilities based in PHP docs and Tomcat's source code.

In PHP, use setrawcookie() instead of setcookie():

I will add that

It might be easier for someone to spot what this file is for when
downloading through a package manager.
Otherwise "legit" encoded pluses will be replaced incorrectly

This is based on @nanaya's comment at #70 (comment)
@FagnerMartinsBrack
Copy link
Member Author

@dezlov, added on 16a8b8c.

Only document the "read converter" as a property when using along with the "write converter".
FagnerMartinsBrack added a commit that referenced this pull request Nov 8, 2015
Add write converter in addition to read converter

Closes gh-71. Closes gh-70.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant