-
Notifications
You must be signed in to change notification settings - Fork 2.1k
export package.json #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export package.json #727
Conversation
I‘d rather not litter the package.json with non-standard fields, and it seems it isn‘t strictly necessary according to aforementioned documentation. |
No, it's about the "package.json" not being accessible to the outside world. Doesn't matter who or what is trying to read the package.json file, anything outside of this module's own files can't look at the file cuz it's not defined as an export. This is very standard & has been part of the ESM resolution algorithm and official documentation + example since very early days. |
Thanks for the quick look @carhartl! As @lukeed mentions above, this is not introducing the non-standard field (I assume you are referring the the
|
Thanks for the PR, and apologies for taking too quick a look.. |
Thanks, appreciate it! |
@odeniso @lukeed I've created a new release so the fix becomes available: https://github.com/js-cookie/js-cookie/releases/tag/v3.0.1 |
here is some more context from within the svelte project