Skip to content

Add license info in order to release with webjars #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

axos88
Copy link
Contributor

@axos88 axos88 commented Oct 8, 2015

Add MIT license

@FagnerMartinsBrack
Copy link
Member

Is this for automated tools that audit the licenses in all packages? Just curious to document the use case.

In the mean time are you getting the license information from package.json? Or this is a blocker for you?

@axos88
Copy link
Contributor Author

axos88 commented Oct 8, 2015

This is a blocker, webjars requires the license to be specified in bower.json
As a fallback it - as they state - it trolls through the git repo, searching for familiar files (license, license.md, and alike), but not MIT-LICENSE.TXT.

http://www.webjars.org/bower

@axos88
Copy link
Contributor Author

axos88 commented Oct 8, 2015

I am currently using js-cookie by copying the file contents into my project as a workaround, but this would fix would be a welcome change.

@FagnerMartinsBrack
Copy link
Member

Got it, thanks.

X-Ref: webjars/webjars#1225

@axos88 axos88 deleted the patch-2 branch October 11, 2015 17:40
@axos88
Copy link
Contributor Author

axos88 commented Oct 11, 2015

Can you please also release this change with a patch version bump in bower?

@FagnerMartinsBrack
Copy link
Member

Can you please also release this change with a patch version bump in bower?

Of course, Bower picks the new version automatically, when I release in npm it will automatically be released in Bower too =)

I will probably release a patch version tomorrow, but no worries, you can be sure this will be in the next version :)

@axos88
Copy link
Contributor Author

axos88 commented Oct 12, 2015

Thanks. Can you please leave a message here when you do?

@FagnerMartinsBrack
Copy link
Member

@axos88
Copy link
Contributor Author

axos88 commented Oct 17, 2015

Awesome, thanks, it's working.

FagnerMartinsBrack pushed a commit that referenced this pull request Aug 19, 2017
Also renames LICENSE to automatically be picked up by npm and other tools (see gh-99).

Closes gh-221.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants