remove unused parameter (GoogleCloudPlatform#3402)

averikitsch · web-flow · commit b75c9aa5106d · 2020-07-22T10:51:12.000-07:00
* remove unused parameter

* Update tests
diff --git a/logging/cloud-client/pom.xml b/logging/cloud-client/pom.xml
@@ -67,7 +67,7 @@
         <configuration>
           <classesDirectory>${project.build.outputDirectory}</classesDirectory>
           <forkCount>3</forkCount>
-          <argLine>-Xmx1024m -XX:MaxPermSize=256m</argLine>
+          <argLine>-Xmx1024m</argLine>
         </configuration>
         <executions>
           <execution>
diff --git a/logging/cloud-client/src/main/java/com/example/logging/ListLogs.java b/logging/cloud-client/src/main/java/com/example/logging/ListLogs.java
@@ -22,9 +22,7 @@
 import com.google.cloud.logging.Logging.EntryListOption;
 import com.google.cloud.logging.LoggingOptions;
 
-/**
- * List logs programmatically using the StackDriver Logging API.
- */
+/** List logs programmatically using the StackDriver Logging API. */
 public class ListLogs {
 
   /** Expects an existing Stackdriver log name as an argument. */
@@ -40,15 +38,13 @@ public static void main(String... args) throws Exception {
       String logFilter = "logName=projects/" + options.getProjectId() + "/logs/" + logName;
 
       // List all log entries
-      Page<LogEntry> entries = logging.listLogEntries(
-          EntryListOption.filter(logFilter));
+      Page<LogEntry> entries = logging.listLogEntries(EntryListOption.filter(logFilter));
       do {
         for (LogEntry logEntry : entries.iterateAll()) {
           System.out.println(logEntry);
         }
         entries = entries.getNextPage();
       } while (entries != null);
-
     }
     // [END logging_list_log_entries]
   }
diff --git a/logging/cloud-client/src/test/java/com/example/logging/LoggingIT.java b/logging/cloud-client/src/test/java/com/example/logging/LoggingIT.java
@@ -26,15 +26,13 @@
 import java.io.ByteArrayOutputStream;
 import java.io.PrintStream;
 import java.util.Collections;
-import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
 
-/**
- * Tests for quickstart sample.
- */
+/** Tests for quickstart sample. */
 @RunWith(JUnit4.class)
 @SuppressWarnings("checkstyle:abbreviationaswordinname")
 public class LoggingIT {
@@ -44,9 +42,9 @@ public class LoggingIT {
 
   private ByteArrayOutputStream bout;
   private PrintStream out;
-  private Logging logging = LoggingOptions.getDefaultInstance().getService();
+  private static Logging logging = LoggingOptions.getDefaultInstance().getService();
 
-  private void deleteLog(String logName) {
+  private static void deleteLog(String logName) {
     logging.deleteLog(logName);
   }
 
@@ -57,8 +55,8 @@ public void setUp() {
     System.setOut(out);
   }
 
-  @After
-  public void tearDown() {
+  @AfterClass
+  public static void tearDown() {
     // Clean up created logs
     deleteLog(QUICKSTART_LOG);
     deleteLog(TEST_WRITE_LOG);
@@ -73,13 +71,14 @@ public void testQuickstart() throws Exception {
     assertThat(got).contains("Logged: Hello, world!");
   }
 
-  @Test(timeout = 60000)
+  @Test(timeout = 30000)
   public void testWriteAndListLogs() throws Exception {
     // write a log entry
-    LogEntry entry = LogEntry.newBuilder(StringPayload.of("Hello world again"))
-        .setLogName(TEST_WRITE_LOG)
-        .setResource(MonitoredResource.newBuilder("global").build())
-        .build();
+    LogEntry entry =
+        LogEntry.newBuilder(StringPayload.of("Hello world again"))
+            .setLogName(TEST_WRITE_LOG)
+            .setResource(MonitoredResource.newBuilder("global").build())
+            .build();
     logging.write(Collections.singleton(entry));
     // flush out log immediately
     logging.flush();
