Skip to content

Conversation

bkoelman
Copy link
Member

Fixes and optimizations in ToString() calls. See the commit messages for details.

Fixes #1779.

QUALITY CHECKLIST

@bkoelman bkoelman changed the title String join Fixes and optimizations in ToString() calls Aug 27, 2025
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 87.93103% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.01%. Comparing base (7f18865) to head (15ad01e).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/JsonApiDotNetCore/Queries/FieldSelection.cs 57.14% 3 Missing ⚠️
...ns/Resources/Annotations/ResourceFieldAttribute.cs 0.00% 0 Missing and 1 partial ⚠️
...piDotNetCore/Queries/Expressions/SortExpression.cs 50.00% 0 Missing and 1 partial ⚠️
...re/Queries/Expressions/SparseFieldSetExpression.cs 50.00% 0 Missing and 1 partial ⚠️
...e/Serialization/Response/ResourceObjectTreeNode.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1780      +/-   ##
==========================================
- Coverage   92.04%   92.01%   -0.03%     
==========================================
  Files         475      475              
  Lines       14724    14730       +6     
  Branches     2331     2339       +8     
==========================================
+ Hits        13552    13554       +2     
- Misses        770      772       +2     
- Partials      402      404       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bkoelman bkoelman marked this pull request as ready for review August 28, 2025 00:19
@bkoelman bkoelman merged commit 5f85f93 into master Aug 28, 2025
16 checks passed
@bkoelman bkoelman deleted the string-join branch August 28, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect separator in SparseFieldSetExpression.ToFullString
1 participant