Skip to content

Support underscore 1.7 and newer #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2019
Merged

Support underscore 1.7 and newer #332

merged 1 commit into from
May 28, 2019

Conversation

phillip-tsui-avalara
Copy link
Contributor

@phillip-tsui-avalara phillip-tsui-avalara commented Apr 4, 2019 •
edited
Loading

The underscore library made a breaking change with version 1.7. _.template() now returns a function.

https://underscorejs.org/#template

@schmunk42
Copy link
Collaborator

As far as I can see we need to specify the constraint first, like underscore < 1.7 for the current code and the make this change and also update the constraint to underscore >= 1.7, right? Or is this somehow backward-compatible?

CC: @marc7000 @pmk65

@pmk65
Copy link
Collaborator

pmk65 commented May 28, 2019

As far as I can see we need to specify the constraint first, like underscore < 1.7 for the current code and the make this change and also update the constraint to underscore >= 1.7, right? Or is this somehow backward-compatible?

I would say just support the latest version.

@schmunk42
Copy link
Collaborator

Sorry for taking so long ... this is an optional dependency, right?
Maybe we should also add a version note in the readme.

@pmk65
Copy link
Collaborator

pmk65 commented May 28, 2019

Sorry for taking so long ... this is an optional dependency, right?
Maybe we should also add a version note in the readme.

It's one of the external template engines you can use.

@schmunk42 schmunk42 self-requested a review May 28, 2019 12:54
@schmunk42 schmunk42 merged commit 7270d88 into json-editor:master May 28, 2019
schmunk42 added a commit that referenced this pull request May 28, 2019
@schmunk42
📝 about underscore version
015cc77 
- see also #332
@schmunk42 schmunk42 mentioned this pull request May 28, 2019
Merged
@pmk65
Copy link
Collaborator

pmk65 commented Jun 16, 2019

@phillip-tsui-avalara Do you have any schema examples that uses underscore templates, you could share?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmunk42 schmunk42 schmunk42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phillip-tsui-avalara @schmunk42 @pmk65