Fix lazy loaded nested associations #154
Open
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing on rubocop violations, however they all have nothing to do with my changes. |
|
Thanks @tlconnor, I'll take a look. |
3 tasks
|
Hi @stas! Will this be included/fixed in v3? |
|
@btagliani yup, we'll be deprecating the API for lazy relationship. Please take a look at the #141 for more details. |
|
👍 |
|
Recently we are facing this issue : #246 Even though lazy loading api will be deprecated, this fix is relevant for v2 users. I hope this to be merged, and 2.2.1 version to be released. Thanks for your work. For someone who are finding answers: Use this https://github.com/veeqo/jsonapi-serializer fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129
What is the current behavior?
Relationships blocks are empty when including nested lazy loaded relationships.
What is the new behavior?
Relationship blocks are properly populated when including nested lazy loaded relationships. The behavior is now consistent with the non-lazy behavior.
The root cause of the problem was that the
includes_listpassed to#record_hashwas not correctly formatted, resulting inincludedalways beingfalse. The behavior of#record_hashis now consistent with#get_included_records.Checklist
Please make sure the following requirements are complete:
features)