Skip to content

Accept infinite function paramaters #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2022
Merged

Accept infinite function paramaters #25

merged 3 commits into from
Jun 18, 2022

Conversation

appleplectic
Copy link
Contributor

No description provided.

@ppaska
Copy link
Contributor

ppaska commented Jun 14, 2022

Very good catch @appleplectic . Thanks for that.
I will be happy to accept your PR. But, there is one other place that needs to be changed. Please have a look at evaluatorAsync

jspython/src/evaluator/evaluatorAsync.ts

Line 166 in 8d98398

private async invokeFunctionAsync(func: (...args: unknown[]) => unknown, fps: unknown[],

At the moment, evaluator and evaluatorAsync contain duplicated logic. This will be refactored in the nearest future. But, for now, we have to maintain the same logic in both files.

Thanks,
Pavlo

ppaska
ppaska reviewed Jun 14, 2022
View reviewed changes
Copy link
Contributor

@ppaska ppaska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please apply the same changes to invokeFunctionAsync

jspython/src/evaluator/evaluatorAsync.ts

Line 166 in 8d98398

private async invokeFunctionAsync(func: (...args: unknown[]) => unknown, fps: unknown[],

ppaska
ppaska requested changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@ppaska ppaska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evaluatorAsync needs to be changed as well

jspython/src/evaluator/evaluatorAsync.ts

Line 166 in 8d98398

private async invokeFunctionAsync(func: (...args: unknown[]) => unknown, fps: unknown[],

@ppaska ppaska mentioned this pull request Jun 15, 2022
Closed
@N-Pelletant
Copy link

@appleplectic is not spreading the correct parameter. He is spreading args when he should be spreading fps

appleplectic
appleplectic commented Jun 15, 2022
View reviewed changes
Copy link
Contributor Author

@appleplectic appleplectic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the other function and spread fps

@ppaska ppaska merged commit a26f5d2 into jspython-dev:DEV-v2 Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppaska ppaska ppaska requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@appleplectic @ppaska @N-Pelletant @ancientstraits