Skip to content
This repository was archived by the owner on Nov 8, 2018. It is now read-only.

Skip deprecation warning when version set to every. #35

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Sep 20, 2016

EOM

@jmcarp
Copy link
Contributor Author

jmcarp commented Sep 20, 2016

Sorry, misread the concourse docs. Not sure I understand your suggestion--if the deprecation warning describes the get, why condition it on the source? Should I just close this?

@jtarchie
Copy link
Owner

It is on the get, but I the resource that is being executed because it has no idea that you specified version: every. There is actually no meta information provided to the resource about version.

In the README, there is a every field that I provide to enable support for version: every, it takes different logic than in the check step.

@jmcarp jmcarp force-pushed the conditional-deprecation branch from 1f7b200 to 14df65d Compare September 27, 2016 13:38
@jmcarp
Copy link
Contributor Author

jmcarp commented Sep 27, 2016

Makes sense--patch updated.

@jtarchie jtarchie merged commit 687fe0f into jtarchie:master Sep 27, 2016
@jtarchie
Copy link
Owner

Thanks, I will push out a new version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants