This repository was archived by the owner on Nov 8, 2018. It is now read-only.
Added basebranch git config parameter #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the mock api / stub_json parameter had to be adjusted to reflect the new `base: ref: key` response. This is because the tests run in tmpdirs which set the git config parameters each time using the common in.rb/output function, and if we don't set them for each of the tests this function will fail.
|
Looks good. Later I'll run it through the pipeline and release. Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the mock api / stub_json parameter had to be adjusted to reflect the new
base: ref: keyresponse. This is because the tests run in tmpdirs which set the git config parameters each time using the common in.rb/output function, and if we don't set them for each of the tests this function will fail.