test: ignore context.Canceled in acquireWithCancel (coder#17448)

spikecurtis · web-flow · commit b3aba6dab7fc · 2025-04-17T16:17:19.000+04:00
fixes coder/internal#584 Ignore canceled error when sending an acquired job, since dRPC is racy and will sometimes return this error even after successfully sending the job, if the test is quickly finished.
diff --git a/provisionerd/provisionerd_test.go b/provisionerd/provisionerd_test.go
@@ -1270,6 +1270,11 @@ func (a *acquireOne) acquireWithCancel(stream proto.DRPCProvisionerDaemon_Acquir
 		return nil
 	}
 	err := stream.Send(a.job)
-	assert.NoError(a.t, err)
+	// dRPC is racy, and sometimes will return context.Canceled after it has successfully sent the message if we cancel
+	// right away, e.g. in unit tests that complete. So, just swallow the error in that case. If we are canceled before
+	// the job was acquired, presumably something else in the test will have failed.
+	if !xerrors.Is(err, context.Canceled) {
+		assert.NoError(a.t, err)
+	}
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -1270,6 +1270,11 @@ func (a *acquireOne) acquireWithCancel(stream proto.DRPCProvisionerDaemon_Acquir`
`1270`	`1270`	`return nil`
`1271`	`1271`	`}`
`1272`	`1272`	`err := stream.Send(a.job)`
`1273`		`- assert.NoError(a.t, err)`
	`1273`	`+ // dRPC is racy, and sometimes will return context.Canceled after it has successfully sent the message if we cancel`
	`1274`	`+ // right away, e.g. in unit tests that complete. So, just swallow the error in that case. If we are canceled before`
	`1275`	`+ // the job was acquired, presumably something else in the test will have failed.`
	`1276`	`+ if !xerrors.Is(err, context.Canceled) {`
	`1277`	`+ assert.NoError(a.t, err)`
	`1278`	`+ }`
`1274`	`1279`	`return nil`
`1275`	`1280`	`}`