Skip to content

Conversation

baloo
Copy link
Collaborator

@baloo baloo commented Aug 29, 2014

No description provided.

@baloo baloo force-pushed the features/parse-gtid branch 3 times, most recently from 6da3bac to e25628c Compare August 29, 2014 08:09

@property
def gtid(self):
gtid = "%s%s%s%s-%s%s-%s%s-%s%s-%s%s%s%s%s%s" %\
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way I can understand what this line is doing? :D

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:))
I'm trying to restore the gtid format
see http://dev.mysql.com/doc/refman/5.6/en/replication-gtids-concepts.html

Couldn't find a better implementation of it :/

@baloo baloo force-pushed the features/parse-gtid branch from e25628c to 5e96c89 Compare August 29, 2014 09:40
def gtid(self):
"""GTID = source_id:transaction_id
Eg: 3E11FA47-71CA-11E1-9E33-C80AA9429562:23"""
gtid = "%s%s%s%s-%s%s-%s%s-%s%s-%s%s%s%s%s%s" %\
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjoernhaeuser Is it more clear this way ?

@bjoernhaeuser
Copy link
Collaborator

What do you think about adding the link directly into the source code? I would merge it afterwards. Thanks!

Feel free to add yourself to the contributors list :)

@julien-duponchelle
Copy link
Owner

Nice contribution @baloo , i agree with @bjoernhaeuser we can add the link in the source it will help us in the futur.

@baloo baloo force-pushed the features/parse-gtid branch from 5e96c89 to 465605f Compare August 29, 2014 14:24
@baloo
Copy link
Collaborator Author

baloo commented Aug 29, 2014

done

@baloo
Copy link
Collaborator Author

baloo commented Aug 29, 2014

BTW, i'm currently trying to implement the MASTER_AUTO_POSITION feature with gtids. PR to come.

@julien-duponchelle
Copy link
Owner

Thanks it's merged

julien-duponchelle added a commit that referenced this pull request Aug 29, 2014
@julien-duponchelle julien-duponchelle merged commit b50dea6 into julien-duponchelle:master Aug 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants