remove default server_id as discussed in #80 #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connection_settings was also changed to arg since it's essential and kwargs default value should not be mutable.
db4274a to
5744a18
Compare
|
We need to move it, because arguments without default must be before the one with an default, right? |
|
yes, args must before kwargs. |
|
I think we can merge or something is missing? |
|
👍 |
julien-duponchelle
added a commit
that referenced
this pull request
Sep 10, 2014
remove default server_id as discussed in #80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change may cause compatibility issue for previous versions.