Skip to content

Improve message of discovery issues for ineffective @Order annotations #4718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Improve message of discovery issues for ineffective @Order annotations #4718

merged 2 commits into from
Jul 3, 2025

Conversation

marcphilipp
Copy link
Member

Overview

Resolves #4713.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp marcphilipp self-assigned this Jul 3, 2025
sbrannen
sbrannen requested changes Jul 3, 2025
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I only suggested the use of text blocks.

sbrannen
sbrannen requested changes Jul 3, 2025
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a second-pass review.

@marcphilipp marcphilipp merged commit 9549b59 into main Jul 3, 2025
14 checks passed
@marcphilipp marcphilipp deleted the marc/4713-improve-disco-issue-message-ineffective-order-annotation branch July 3, 2025 10:46
marcphilipp added a commit that referenced this pull request Jul 3, 2025
@marcphilipp
Improve message of discovery issues for ineffective @Order annotati…
8a0be13 
…ons (#4718)

Resolves #4713.

(cherry picked from commit 9549b59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@marcphilipp marcphilipp

Labels
component: Jupiter theme: diagnostics theme: reporting type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve "Ineffective @Order annotation" discovery issue by mentioning meta-annotations
2 participants
@marcphilipp @sbrannen