Use DataFlowIssue as suppression name alias for NullAway
#4779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nice! Alternatively, it Would be nice if NullAway and IntelliJ could agree on a warning category or IntelliJ could recognize |
4efe485 to
6dedfb4
Compare
DataFlowIssue as NullAway suppression name aliasDataFlowIssue as suppression name alias
|
@scordio Any objections on merging this without the new DSL? |
|
No objections! I will be able to rebase this PR only later in the day. I might contribute to the plugin project too but it'll take a few more days before I can jump on it. |
6dedfb4 to
2224f6b
Compare
marcphilipp
approved these changes
Aug 11, 2025
DataFlowIssue as suppression name aliasDataFlowIssue as suppression name alias
DataFlowIssue as suppression name aliasDataFlowIssue as suppression name alias
DataFlowIssue as suppression name aliasDataFlowIssue as suppression name alias for NullAway
marcphilipp
reviewed
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on a NullAway enhancement that allows setting suppression name aliases, like the JetBrains
DataFlowIssueinspection.As I'm also testing my changes against the JUnit codebase, I'm opening this PR as a draft to showcase the idea, and I'd be happy to finalize it if the team agrees.
Prerequisites
SuppressionNameAliasesconfig optiongradle-nullaway-pluginfor the corresponding DSL (workaround demonstrated in the PR)I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations