Fix marked checkbox with ambiguous Markdown link #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasham
pushed a commit
that referenced
this pull request
Oct 11, 2016
Merge pull request #4 from Newt0n/master
jwasham
pushed a commit
that referenced
this pull request
Jan 11, 2017
translate Don't feel you aren't smart enough
jwasham
pushed a commit
that referenced
this pull request
Oct 11, 2017
Before you Get Started topic translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request fixes bug in the Markdown parser used by GitHub to translate
[x]into HTML checkboxes, the way it is currently written makes the transpiler believe that the text in between parenthesis is actually part of a Markdown link with this syntax[title](href)which makes me believe that the parser is taking/\[x\][^(]+\([^)]+\)/(notice the pattern in between the braces and the parenthesis).So instead of this:
... it is rendering this: