Skip to content
This repository was archived by the owner on Jul 11, 2025. It is now read-only.

Propagate future.exception in producer/kafka.py _wait_on_metadata #157

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Propagate future.exception in producer/kafka.py _wait_on_metadata #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b3ca24
Propagate future.exception
mkromer-tc Jul 14, 2020
dc5fe87
Use failed topics not set of topics in error message
mkromer-tc Jan 11, 2021
c3cbf95
Merge branch 'master' into propagate-publish-errors
wbarnha Mar 18, 2024
7b425cb
Merge branch 'master' into propagate-publish-errors
wbarnha Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka/consumer/fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,7 @@ def _parse_fetched_data(self, completed_fetch):

elif error_type is Errors.TopicAuthorizationFailedError:
log.warning("Not authorized to read from topic %s.", tp.topic)
raise Errors.TopicAuthorizationFailedError(set(tp.topic))
raise Errors.TopicAuthorizationFailedError(tp.topic)
elif error_type is Errors.UnknownError:
log.warning("Unknown error fetching data for topic-partition %s", tp)
else:
Expand Down
2 changes: 2 additions & 0 deletions kafka/producer/kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,6 +697,8 @@ def _wait_on_metadata(self, topic, max_wait):
self._sender.wakeup()
metadata_event.wait(max_wait - elapsed)
elapsed = time.time() - begin
if future.exception:
raise future.exception
if not metadata_event.is_set():
raise Errors.KafkaTimeoutError(
f"Failed to update metadata after {max_wait:.1f} secs.")
Expand Down