Skip to content

Add delete records method support for kafka admin api #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add delete records method support for kafka admin api #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99ed20f
Add delete records method support for kafka admin api
10101010 Jun 1, 2020
9d873c4
Merge branch 'master' into add-delete-records-support
wbarnha Mar 8, 2024
7dc60f2
Merge branch 'master' into add-delete-records-support
wbarnha Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions kafka/admin/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,62 @@ def create_partitions(self, topic_partitions, timeout_ms=None, validate_only=Fal
.format(version))
return self._send_request_to_controller(request)

def delete_records(self, records_to_delete, timeout_ms=None):
"""Delete records whose offset is smaller than the given offset of the corresponding partition.

:param records_to_delete: ``{TopicPartition: int}``: The earliest available offsets for the
given partitions.

:return: List of DeleteRecordsResponse
"""
timeout_ms = self._validate_timeout(timeout_ms)
version = self._matching_api_version(MetadataRequest)

topics = set()

for topic2partition in records_to_delete:
topics.add(topic2partition.topic)

request = MetadataRequest[version](
topics=list(topics),
allow_auto_topic_creation=False
)

future = self._send_request_to_node(self._client.least_loaded_node(), request)

self._wait_for_futures([future])
response = future.value

version = self._matching_api_version(DeleteRecordsRequest)

PARTITIONS_INFO = 3
NAME = 1
PARTITION_INDEX = 1
LEADER = 2

partition2leader = dict()

for topic in response.topics:
for partition in topic[PARTITIONS_INFO]:
t2p = TopicPartition(topic=topic[NAME], partition=partition[PARTITION_INDEX])
partition2leader[t2p] = partition[LEADER]

responses = []

for topic2partition in records_to_delete:
request = DeleteRecordsRequest[version](
topics=[(topic2partition.topic, [(topic2partition.partition, records_to_delete[topic2partition])])],
timeout_ms=timeout_ms
)
# Sending separate request for each partition leader
future = self._send_request_to_node(partition2leader[topic2partition], request)
self._wait_for_futures([future])

response = future.value
responses.append(response)

return responses

# delete records protocol not yet implemented
# Note: send the request to the partition leaders

Expand Down
32 changes: 32 additions & 0 deletions kafka/protocol/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,38 @@ class DeleteTopicsRequest_v3(Request):
]


class DeleteRecordsResponse_v0(Response):
API_KEY = 21
API_VERSION = 0
SCHEMA = Schema(
('topics', Array(
('name', String('utf-8')),
('partitions', Array(
('partition_index', Int32),
('low_watermark', Int64),
('error_code', Int16))))),
('throttle_time_ms', Int32)
)


class DeleteRecordsRequest_v0(Request):
API_KEY = 21
API_VERSION = 0
RESPONSE_TYPE = DeleteRecordsResponse_v0
SCHEMA = Schema(
('topics', Array(
('name', String('utf-8')),
('partitions', Array(
('partition_index', Int32),
('offset', Int64))))),
('timeout_ms', Int32)
)


DeleteRecordsResponse = [DeleteRecordsResponse_v0]
DeleteRecordsRequest = [DeleteRecordsRequest_v0]


class ListGroupsResponse_v0(Response):
API_KEY = 16
API_VERSION = 0
Expand Down