add validate_config function for msk module #176
Conversation
|
@wbarnha, let me know what you think. With the current release, authenticating towards MSK using the |
To be honest, I haven't had the chance to appropriately update documentation in my own GitHub Pages environment yet. Thank you for this PR, I took it in good faith that the original implementation was properly tested against an AWS MSK instance and there were no issues. |
|
The original implementation seemed good, it was just this minor thing that was off! No worries, happy to contribute 🙌🏾 Thanks for fast approval and release, appreciate it 👌🏾 |
What
I had issues connecting to our MSK cluster using the kafka-python-ng library and noticed that there was a call to the function
validate_config()when usingSASL_SSL, which was not implemented for the MSK module.Similar to the other oauth modules, it is assumed in the conn.py code that there is a function that does the same check that is found in conn.py and added this.
Why
Connection issues to MSK
References
#170 and potentially also @mattoberle's implementation in https://github.com/mattoberle/kafka-python/tree/feature/2232-AWS_MSK_IAM