Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terms): fixed EmptyCriterion bug with ComplexCriterion #732

Merged
merged 2 commits into from
Sep 22, 2023
Merged

fix(terms): fixed EmptyCriterion bug with ComplexCriterion #732

merged 2 commits into from
Sep 22, 2023

Conversation

GeorgiySurkov
Copy link
Contributor

issue: #327

@GeorgiySurkov GeorgiySurkov requested a review from a team as a code owner June 14, 2023 09:43
AzisK
AzisK approved these changes Sep 22, 2023
View reviewed changes
Copy link

@AzisK AzisK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job and thanks for working on this

@AzisK
Copy link

AzisK commented Sep 22, 2023

For some reason the CI tests did not run with this PR. Could you update the code with the newest from the master branch?

@GeorgiySurkov
Copy link
Contributor Author

Yes, of course!

@coveralls
Copy link

Coverage Status

coverage: 98.43% (+0.007%) from 98.423% when pulling ab62819 on GeorgiySurkov:master into ea9cc5b on kayak:master.

@AzisK
Copy link

AzisK commented Sep 22, 2023

It looks good and I am merging this but version bump will come later

@AzisK AzisK merged commit 12a8f33 into kayak:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzisK AzisK AzisK approved these changes

Assignees

@GeorgiySurkov GeorgiySurkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeorgiySurkov @AzisK @coveralls