-
-
Notifications
You must be signed in to change notification settings - Fork 341
LoggerStore + NetworkLogger + Redacted + Patterns #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I probably need to make some changes to the demo project, let me check 👀 |
Alright, demo project compiles. But still need to update docs. And also been looking at the implementation and maybe the best route is actually to extract that StoreRequest logic from LoggerStore and create a new small type like RequestLogger 🤔 |
Also because |
Hm, I also realized this is a breaking change now 😅 |
I have pushed a commit with a dedicated |
56911cf
to
a398f26
Compare
Hey, thanks for the PR, @wow-such-amazing. I'll review it as soon as I get a chance. |
I've extracted fields that are responsible for redacting into its own struct
Redacted
fromNetworkLogger.Configuration
. I then created an internal typeRedacted.Patterns
that mimics what was insideNetworkLogger
itself and what was insideNetworkLogger+Redacting
.This way we can set separately
Redacted
struct onto theNetworkLogger
andLoggerStore
configurations and they would follow the same approach.We can also set same
Redacted
for both if we'd like to follow the same logic in both.Let me know what you think 🙏
Addresses #327
P.S. Sorry for spamming with many comments here 😅