Add check for a ZERO value #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JS language considers the value ZERO to be "false". This has to do with the fact that the numeric representation of true/false are 1/0. This was of course preventing the initial value of a numeric field to be set to zero since there was a check on the mounted function that saw if the value was defined. I've added a simple OR case, where if the value was evaluated to FALSE than we check again for if the value is zero. This fixed the case where the value ZERO was not being shown when it was deliberately chosen. It did break another case when we pass an empty string. To fix it I also test if the original value is not empty (which would be evaluated to zero)
|
This PR was raised in order to fix the Issue mentioned in #103 |
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 98.00% 98.03% +0.03%
==========================================
Files 1 1
Lines 50 51 +1
Branches 20 21 +1
==========================================
+ Hits 49 50 +1
Partials 1 1
Continue to review full report at Codecov.
|
|
Anything I might have to do here still? I don't think any update to the docs is necessary... |
|
thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JS language considers the value ZERO to be
"false". This has to do with the fact that the
numeric representation of true/false are 1/0.
This was of course preventing the initial value
of a numeric field to be set to zero since there
was a check on the mounted function that saw if
the value was defined.
I've added a simple OR case, where if the value
was evaluated to FALSE than we check again for
if the value is zero. This fixed the case where
the value ZERO was not being shown when it was
deliberately chosen.
It did break another case when we pass an empty
string. To fix it I also test if the original value
is not empty (which would be evaluated to zero)