Skip to content

Fixes linter F821 (undefined name) #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

Fixes linter F821 (undefined name) #1285

merged 1 commit into from
May 22, 2018

Conversation

AndreMiras
Copy link
Member

Fixes or ignores some undefined names.
Plus deletes get_directory() dead code.

@AndreMiras
Fixes linter F821 (undefined name)
154f1e5 
Fixes or ignores some undefined names.
Plus deletes `get_directory()` dead code.
AndreMiras
AndreMiras commented May 22, 2018
View reviewed changes
pythonforandroid/util.py
@@ -128,20 +123,3 @@ def is_exe(fpath):
return exe_file

return None


def get_directory(filename):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead code

@inclement inclement merged commit 442a3a8 into kivy:master May 22, 2018
@inclement
Copy link
Member

Thanks!

@AndreMiras AndreMiras deleted the feature/tox_flake8_undefined_names branch October 6, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreMiras @inclement