Improves gevent recipe robustness #1307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0bdc29 to
489eb5c
Compare
Tries to match and replace patterns to be moved from one environment variable to another rather than hard coding it. That way unexpected flags added to parent recipes hierarchy also get handled. This issue popped when testing kivy#793
489eb5c to
cce4d5e
Compare
opacam
pushed a commit
to opacam/python-for-android
that referenced
this pull request
Jun 30, 2018
This changes affect almost all recipes inherited from PythonRecipe. Some recipes where affected by the changes and were modified in order to succesfully build. One of the changes forces to get python headers and linkages for all the CythonRecipe,so, all inherited recipes from CythonRecipe should be reviewed and cleaned up if necessary and all the recipes who inherited from PythonRecipe probably should be reviewed, taking into account the fact pointed by user @AndreMiras, some flags of some recipes are wrong: - CFLAGS may only be used to specify C compiler flags, for macro definitions use CPPFLAGS - LDFLAGS may only be used to specify linker flags, for libraries use LIBS Resolves: kivy#668 See also: kivy#1307
Closed
|
Sorry for falling behind on this, is it still good to merge? |
|
Thanks for asking, I think it's still valid, but I didn't get much time to double check. I'd like to have the feedback from #1333 so I'm waiting for his logs #1333 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to match and replace patterns to be moved from one environment variable to another rather than hard coding it.
That way unexpected flags added to parent recipes hierarchy also get handled.
This issue popped when testing #793
Also added some logs that produced the following output:
Note that since it drops all the explicit
-l,-L,-Iit now relies on the WIP #793 and was tested with it. I deployed an app on device and it worked OK.I'll test it again once #793 gets merged, in case things have moved.