Skip to content

Improves gevent recipe robustness #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AndreMiras
Copy link
Member

@AndreMiras AndreMiras commented Jun 29, 2018

Tries to match and replace patterns to be moved from one environment variable to another rather than hard coding it.
That way unexpected flags added to parent recipes hierarchy also get handled.
This issue popped when testing #793

Also added some logs that produced the following output:

[INFO]:    Moved "-DANDROID -D__ANDROID_API__=19 -I/home/andre/.buildozer/crystax-ndk-10.3.2/platforms/android-19/arch-arm -I/home/andre/workspace/EtherollApp/.buildozer/android/platform/build/build/python-installs/etheroll/include/python3.6 -I/home/andre/.buildozer/crystax-ndk-10.3.2/sources/python/3.6/include/python" from CFLAGS to CPPFLAGS.
[INFO]:    Moved "-lm -lcrystax -lpython3.6m" from LDFLAGS to LIBS.

Note that since it drops all the explicit -l, -L, -I it now relies on the WIP #793 and was tested with it. I deployed an app on device and it worked OK.
I'll test it again once #793 gets merged, in case things have moved.

@AndreMiras AndreMiras force-pushed the feature/improve_gevent_recipe_reliability branch from a0bdc29 to 489eb5c Compare June 30, 2018 01:57
Tries to match and replace patterns to be moved from one environment
variable to another rather than hard coding it.
That way unexpected flags added to parent recipes hierarchy also get
handled.
This issue popped when testing kivy#793
@AndreMiras AndreMiras force-pushed the feature/improve_gevent_recipe_reliability branch from 489eb5c to cce4d5e Compare June 30, 2018 13:15
opacam pushed a commit to opacam/python-for-android that referenced this pull request Jun 30, 2018
This changes affect almost all recipes inherited from PythonRecipe. Some recipes where affected by the changes and were modified in order to succesfully build. One of the changes forces to get python headers and linkages for all the CythonRecipe,so, all inherited recipes from CythonRecipe should be reviewed and cleaned up if necessary and all the recipes who inherited from PythonRecipe probably should be reviewed, taking into account the fact pointed by user @AndreMiras, some flags of some recipes are wrong:

  - CFLAGS may only be used to specify C compiler flags, for macro definitions use CPPFLAGS
  - LDFLAGS may only be used to specify linker flags, for libraries use LIBS

Resolves: kivy#668
See also: kivy#1307
@AndreMiras AndreMiras mentioned this pull request Aug 19, 2018
@inclement
Copy link
Member

Sorry for falling behind on this, is it still good to merge?

@AndreMiras
Copy link
Member Author

Thanks for asking, I think it's still valid, but I didn't get much time to double check. I'd like to have the feedback from #1333 so I'm waiting for his logs #1333 (comment)
Basically I would like to see if he has errors regarding LDFLAGS or CFLAGS not being used properly in his log file and see if this PR fixes it for him. That the issue I had back then, but didn't get a chance to verify again since master moved.

@AndreMiras AndreMiras closed this Oct 6, 2018
@AndreMiras AndreMiras deleted the feature/improve_gevent_recipe_reliability branch October 6, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants