Skip to content

Sets default service pythonName, fixes #1049 #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2018
Merged

Sets default service pythonName, fixes #1049 #1371

merged 1 commit into from
Sep 13, 2018

Conversation

AndreMiras
Copy link
Member

In #609 PYTHON_NAME was
being used while potentially null (in the case of basic service folder
method), leading to segfault on setenv() call.

@AndreMiras
Sets default service pythonName, fixes kivy#1049
0981808 
In kivy#609 `PYTHON_NAME` was
being used while potentially null (in the case of basic service folder
method), leading to segfault on `setenv()` call.
@AndreMiras
Copy link
Member Author

While I've also added the fixes for webview and pygame bootstraps, I've only tested it in sdl2.

@AndreMiras AndreMiras mentioned this pull request Sep 12, 2018
Closed
@tito tito merged commit 9e8bb37 into kivy:master Sep 13, 2018
@AndreMiras AndreMiras deleted the feature/ticket1049_fix_android_service_crash branch February 1, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tito tito tito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreMiras @tito