Conditional recipe build fixes #1382 #1401
Conversation
This is a first iteration addressing recipes conditional build. In this version all modified recipes are build in batch with no dependency resolution whatsoever. Also recipes are only built against `python3crystax` target and `sdl2` bootstrap. The list of broken recipes is not fully known, but this script will help finding out. If a recipe is known to be broken, it should be added in the `BROKEN_RECIPES` set to be skipped until it gets fixed.
| - COMMAND='. venv/bin/activate && cd testapps/ && python setup_testapp_python2.py apk --sdk-dir $ANDROID_SDK_HOME --ndk-dir $ANDROID_NDK_HOME --bootstrap sdl2 --requirements python2,numpy' | ||
| - COMMAND='. venv/bin/activate && cd testapps/ && python setup_testapp_python3.py apk --sdk-dir $ANDROID_SDK_HOME --ndk-dir $CRYSTAX_NDK_HOME --requirements python3crystax,setuptools,android,sdl2,pyjnius,kivy' | ||
| # builds only the recipes that moved | ||
| - COMMAND='. venv/bin/activate && ./ci/rebuild_updated_recipes.py' |
There was a problem hiding this comment.
Here's what really changed, the rest is refactoring
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| class BabelRecipe(PythonRecipe): | |||
| name = 'babel' | |||
| version = '2.1.1' | |||
| version = '2.2.0' | |||
There was a problem hiding this comment.
Changed to demo the feature in the this pull request.
Basically babel was updated so it will be rebuild by the CI script.
| @@ -3,6 +3,9 @@ | |||
|
|
|||
|
|
|||
| class CffiRecipe(CompiledComponentsPythonRecipe): | |||
| """ | |||
| Extra system dependencies: autoconf, automake and libtool. | |||
| """ | |||
There was a problem hiding this comment.
Also demonstrate another feature, this recipe should be rebuilt by the script, however it will be skipped because it's currently known to be broken (see BROKEN_RECIPES global). It's a bit like a flake8 ignore list, once the recipe is fixed it should be removed from the list should never break again.
| 'six'] | ||
| install_reqs = ['appdirs', 'colorama>=0.3.3', 'jinja2', 'six', 'enum34'] | ||
| if os.name != 'nt': | ||
| install_reqs.append('sh>=1.10') |
There was a problem hiding this comment.
Well this has nothing to do with this pull request, but I saw this minor refactor and couldn't help, I had to fix it 😄
I can take it out of the PR if you guys prefer.
There was a problem hiding this comment.
Nice I actually added enum34 I forgot about that and it breaks some recipes builds from Python3.6 e.g. pyjnuis
|
You can see it running here https://travis-ci.org/kivy/python-for-android/jobs/440200064 So it could detect that both |
This is a first iteration addressing recipes conditional build.
In this version all modified recipes are build in batch with no
dependency resolution whatsoever.
Also recipes are only built against
python3crystaxtarget andsdl2bootstrap.The list of broken recipes is not fully known, but this script will help
finding out. If a recipe is known to be broken, it should be added in
the
BROKEN_RECIPESset to be skipped until it gets fixed.