Creates non root user in Dockerfile #1429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
commented
Oct 23, 2018
| @@ -36,7 +40,7 @@ ENV ANDROID_NDK_DL_URL="https://dl.google.com/android/repository/${ANDROID_NDK_A | |||
|
|
|||
| # install system dependencies | |||
| RUN apt update -qq && apt install -qq --yes --no-install-recommends \ | |||
| python virtualenv python-pip wget curl lbzip2 patch bsdtar && \ | |||
| python virtualenv python-pip wget curl lbzip2 patch bsdtar sudo && \ | |||
There was a problem hiding this comment.
Added sudo because it could still be useful on interactive shell
AndreMiras
commented
Oct 23, 2018
| RUN "${ANDROID_SDK_HOME}/tools/bin/sdkmanager" "build-tools;26.0.2" | ||
| RUN "${ANDROID_SDK_HOME}/tools/bin/sdkmanager" "platforms;android-19" && \ | ||
| "${ANDROID_SDK_HOME}/tools/bin/sdkmanager" "build-tools;26.0.2" && \ | ||
| chmod +x "${ANDROID_SDK_HOME}/tools/bin/avdmanager" |
There was a problem hiding this comment.
Non root user also need execution rights, hence the chmod
Subsequent p4a command will run as unprivileged user. This makes the setup more realistic/closer to an actual setup. Also added .dockerignore so container and host generated files don't conflict.
8ac64b5 to
4871a61
Compare
inclement
approved these changes
Oct 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsequent p4a command will run as unprivileged user.
This makes the setup more realistic/closer to an actual setup.
Also added .dockerignore so container and host generated files don't conflict.